CVE-2023-40015

Advisory

Vyper is affected by CVE-2023-40015: For the following (probably non-exhaustive) list of expressions, the compiler evaluates the arguments from right to left instead of left to right. 'unsafe_add, unsafe_sub, unsafe_mul, unsafe_div, pow_mod256, |, &, ^ (bitwise operators), bitwise_or (deprecated), bitwise_and (deprecated), bitwise_xor (deprecated), raw_call, <, >, <=, >=, ==, !=, in, not in (when lhs and rhs are enums)'. This behavior becomes a problem when the evaluation of one of the arguments produces side effects that other arguments depend on. The following expressions can produce side-effect: state modifying external call , state modifying internal call, 'raw_call', 'pop()' when used on a Dynamic Array stored in the storage, 'create_minimal_proxy_to', 'create_copy_of', 'create_from_blueprint'. This issue has not yet been patched. Users are advised to make sure that the arguments of the expression do not produce side effects or, if one does, that no other argument is dependent on those side effects.
https://github.com/vyperlang/vyper/security/advisories/GHSA-g2xh-c426-v8mf

Affected package

Affected versions

Fixed versions

Vulnerability changelog

Vyper is a Pythonic Smart Contract Language. For the following (probably non-exhaustive) list of expressions, the compiler evaluates the arguments from right to left instead of left to right. `unsafe_add, unsafe_sub, unsafe_mul, unsafe_div, pow_mod256, |, &, ^ (bitwise operators), bitwise_or (deprecated), bitwise_and (deprecated), bitwise_xor (deprecated), raw_call, <, >, <=, >=, ==, !=, in, not in (when lhs and rhs are enums)`. This behaviour becomes a problem when the evaluation of one of the arguments produces side effects that other arguments depend on. The following expressions can produce side-effect: state modifying external call , state modifying internal call, `raw_call`, `pop()` when used on a Dynamic Array stored in the storage, `create_minimal_proxy_to`, `create_copy_of`, `create_from_blueprint`. This issue has not yet been patched. Users are advised to make sure that the arguments of the expression do not produce side effects or, if one does, that no other argument is dependent on those side effects. See CVE-2023-40015.


MISC:https://github.com/vyperlang/vyper/security/advisories/GHSA-g2xh-c426-v8mf: https://github.com/vyperlang/vyper/security/advisories/GHSA-g2xh-c426-v8mf

Resources

• https://github.com/vyperlang/vyper/security/advisories/GHSA-g2xh-c426-v8mf
• https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-40015