Leap.mail

+++++++++++++++++++++

Bugfixes
~~~~~~~~
- `8083 <https://leap.se/code/issues/8083>`_: Allow pixelated UA not interfere with Thunderbird operation.
- Cast local identity (version string) to bytes, avoid TLS transport raising exception.

+++++++++++++++++++++

Features
~~~~~~~~
- `7656 <https://leap.se/code/issues/7656>`_: Emit multi-user aware events.
- `4008 <https://leap.se/code/issues/4008>`_: Add token-based authentication to local IMAP/SMTP services.
- `7889 <https://leap.se/code/issues/7889>`_: Use cryptography instead of pycryptopp to reduce dependencies.
- `7263 <https://leap.se/code/issues/7263>`_: Implement local bounces to notify user of SMTP delivery errors.
- Use twisted.cred to authenticate IMAP/SMTP users.
- Verify plain text signed email.
- Validate signature with attachments.
- Use fingerprint instead of key_id to address keys.


Bugfixes
~~~~~~~~
- `7861 <https://leap.se/code/issues/7861>`_: Use the right succeed function for passthrough encrypted email.
- `7898 <https://leap.se/code/issues/7898>`_: Fix IMAP fetch headers
- `7977 <https://leap.se/code/issues/7977>`_: Decode attached keys so they are recognized by keymanager.
- `7952 <https://leap.se/code/issues/7952>`_: Specify openssl backend explicitely.
- Fix the get_body logic for corner-cases in which body is None (yet-to-be synced docs, mainly).
- Let the inbox used in IncomingMail notify any subscribed Mailbox.
- Adds user_id to Account (fixes Pixelated mail leakage).

Misc
~~~~
- Change IMAPAccount signature, for consistency with a previous Account change.

o Expose generic and protocol-agnostic public mail API.
o Make use of the twisted-based, async soledad API.
o Create a OutgoingMail class that has the logic for encrypting, signing and
sending messages. Factors that logic out of EncryptedMessage so it can be
used by other clients. Closes: 6357.
o Refactor email fetching outside IMAP to its own independient IncomingMail
class. Closes: 6361.
o Adapt to new events api on leap.common. Related to 5359.
o Discover public keys via attachment. Closes: 5937.
o Add public key as attachment. Closes: 6617.
o Parse OpenPGP header and import keys from it. Closes: 3879.
o Don't add any footer to the emails. Closes: 4692.
o Add listener for each email added to inbox in IncomingMail. Closes: 6742.
o Ability to reindex local UIDs after a soledad sync. Closes: 6996.
o Feature: add very basic support for message sequence numbers.
o Send a BYE command to all open connections, so that the MUA is notified
when the server is shutted down.
o Fix nested multipart rendering. Closes: 7244
o Update SMTP gateway docs. Closes 7169.
o Bugfix: fix keyerror when inserting msg on pending_inserts dict.
o Bugfix: Return the first cdoc if no body found
o Lots of style fixes and tests updates.
o If the auth token has expired signal the GUI to request her to log in again
(Closes: 7430)
o don't extract openpgp header if valid attached key (Closes: 7480)
o disable local only tcp bind on docker containers to allow access to IMAP
and SMTP. Related to 7471.

o MessageCollection iterator now creates the LeapMessage with the
collection reference, so setFlags will work properly.
o accountaddMailbox can't allow empty mailbox names since it makes
it impossible to create it later (mailbox__init__ will throw an
error), which makes it impossible to getMailbox or even delete it.

o Footer url shouldn't end in period. Closes 4791.
o Handle non-ascii headers. Closes 5021.
o Soledad writer consumes messages eagerly. Fixes failing
tests. Closes 4715.
o Convert unicode to str when raising exceptions in IMAP server.
Fixes 4830.
o Remove conversion of IMAP folder names to string. This makes the
IMAP server use twisted's transparent 7bit conversion. Fixes
4830.
o Add a flag to be able to reset the session. Closes 4925.
o Check for none in payload detection. Closes 4933.
o Check for flags doc uniqueness before adding a message. Avoids
duplicates of a single message in the same mailbox while copying
or moving. Closes 4949.
o Correctly process attachments when signing. Fixes 5014.
o Fix bug in which destination folder sometimes was not showing
messages after copy/append. Closes 5167.
o Fix unread notifications to client UI. Only INBOX is
notified. Closes 5177.
o Fix bug in which deleted folder wouldn't show its messages
inside. Closes 5179.
o Keep processing after a decryption error. Closes 5307.
o Enqueue unsetting of recent flag. this was holding the new mails
from being displayed soonish.
o Properly parse emails crafted by Mail.app. Fixes 5013.
o Restrict adding outgoing footer to text/plain messages.
o Sanity check on last_uid setter. Avoids incomplete fetches.
o Stop providing hostname for helo in smtp gateway. Fixes 4335.
o Only try to fetch keys for multipart signed or encrypted emails.
Fixes 4671.
o Add a flag for offline mode in imap. Related to 4943.
o Flush IMAP data to disk when stopping. Closes 5095.
o Signal the client when auth token is invalid for syncing Soledad.
Fixes 5191.
o Ability to support SEARCH Commands, limited to HEADER Message-ID.
This is a quick workaround for avoiding duplicate saves in Drafts
Folder. Closes 4209.
o Use a memory store as write-buffer and read-cache.
o Implement IMAP4 non-synchronizing literals (rfc2088), so APPENDs
can be made in a single round-trip. Closes 5190.
o Defer costly operations to a pool of threads.
o Split the internal representation of messages into three distinct
documents: 1) Flags 2) Headers 3) Content.
o Make use of the Twisted MIME interface.
o Add deduplication ability to the save operation, for body and
attachments.
o Add IMessageCopier interface to mailbox implementation, so bulk
moves are costless. Closes 4654.
o Makes efficient use of indexes and count method. Closes 4616.
o Handle correctly unicode characters in emails. Closes 4838.

o Fail gracefully when failing to decrypt incoming messages. Closes
4589.
o Fix a bug when adding a message with empty flags. Closes 4496
o Allow to iterate in an empty mailbox during fetch. Closes 4603
o Add 'signencrypt' preference to OpenPGP header on outgoing
email. Closes 3878.
o Add a header to incoming emails that reflects if a valid signature
was found when decrypting. Closes 4354.
o Add a footer to outgoing email pointing to the address where
sender keys can be fetched. Closes 4526.
o Serialize Soledad Writes for new messages. Fixes segmentation
fault when sqlcipher was been concurrently accessed from many
threads. Closes 4606
o Set remote mail polling time to 60 seconds. Closes 4499