Buildbot

Bug fixes
---------

- Fixed support of SQLAlchemy v1.4 (5992).
- Improved default build request collapsing functionality to take into account properties set by the scheduler and not collapse build requests if they differ (4686).
- Fixed a race condition that would result in attempts to complete unclaimed buildrequests (3762).
- Fixed a race condition in default buildrequest collapse function which resulted in two concurrently submitted build requests potentially being able to cancel each other (4642).
- The `comment-added` event on Gerrit now produces the same branch as other events such as `patchset-created`.
- `GerritChangeSource` and `GerritEventLogPoller` will now produce change events with `branch` attribute that corresponds to the actual git branch on the repository.
- Fixed handling of `GitPoller` state to not grow without bounds and eventually exceed the database field size. (6100)
- Old browser warning banner is no longer shown for browsers that could not be identified (5237).
- Fixed worker lock handling that caused max lock count to be ignored (6132).

Features
--------

- Buildbot can now be configured (via `FailingBuildsetCanceller`) to cancel unfinished builds when a build in a buildset fails.
- `GitHubEventHandler` can now configure authentication token via Secrets management for GitHub instances that do not allow anonymous access
- Buildbot can now be configured (via `OldBuildCanceller`) to cancel unfinished builds when branches on which they are running receive new commits.
- Buildbot secret management can now be used to configure worker passwords.
- Services can now be forced to reload their code via new `canReconfigWithSibling` API.

Deprecations and Removals
-------------------------

- `changes.base.PollingChangeSource` has been fully deprecated as internal uses of it were migrated to replacement APIs.

Bug fixes
---------

- Fixed occasional ``InvalidSpotInstanceRequestID.NotFound`` errors when using spot instances on EC2.
This could have lead to Buildbot launching zombie instances and not shutting them down.
- Improved ``GitPoller`` behavior during reconfiguration to exit at earliest possible opportunity and thus reduce the delay that running ``GitPoller`` incurs for the reconfiguration.
- The docker container for the master now fully builds the www packages.
Previously they were downloaded from pypi which resulted in downloading whatever version was newest at the time (4998).
- Implemented time out for master-side utility processes (e.g. ``git`` or ``hg``) which could break the respective version control poller potentially indefinitely upon hanging.
- Fixed a regression in the ``reconfig`` script which would time out instead of printing error when configuration update was not successfully applied.
- Improved buildbot restart behavior to restore the worker paused state (6074)
- Fixed support for binary patch files in try client (5933)
- Improved handling of unsubscription errors in WAMP which will no longer crash the unsubscribing component and instead just log an error.
- Fixed a crash when a worker is disconnected from a running build that uses worker information for some of its properties (5745).

Improved Documentation
----------------------

- Added documentation about installation Buildbot worker as Windows service.

Features
--------

- ``DebPbuilder`` now supports the ``--othermirror`` flag for including additional repositories
- Implemented support for setting docker container's hostname
- The libvirt latent worker will now wait for the VM to come online instead of disabling the worker during connection establishment process.
The VM management connections are now pooled by URI.
- Buildbot now sends metadata required to establish connection back to master to libvirt worker VMs.
- ``LibVirtWorker`` will now setup libvirt metadata with details needed by the worker to connect back to master.
- The docker container for the master has been switched to Debian.
Additionally, buildbot is installed into a virtualenv there to reduce chances of conflicts with Python packages installed via ``dpkg``.
- BitbucketStatusPush now has renderable build status key, name, and description.
- Pausing a worker is a manual operation which the quarantine timer was overwriting. Worker paused state and quarantine state are now independent. (5611)
- Reduce buildbot_worker wheel package size by 40% by dropping tests from package.

Bug fixes
---------

- Fix missing VERSION file in buildbot_worker wheel package (5948, 4464).
- Fixed error when attempting to specify ``ws_ping_interval`` configuration option (5991).

Bug fixes
---------

- Fixed usage of invalid characters in temporary file names by git-related steps (5949)
- Fixed parsing of URLs of the form https://api.bitbucket.org/2.0/repositories/OWNER/REPONAME in BitbucketStatusPush. These URLs are in the sourcestamps returned by the Bitbucket Cloud hook.
- Brought back the old (pre v2.9.0) behavior of the ``FileDownload`` step to act more gracefully by returning ``FAILURE`` instead of raising an exception when the file doesn't exist on master. This makes use cases such as ``FileDownload(haltOnFailure=False)`` possible again.
- Fixed issue with ``getNewestCompleteTime`` which was returning no completed builds, although it could.
- Fixed the ``Git`` source step causing last active branch to point to wrong commits. This only affected the branch state in the local repository, the checked out code was correct.
- Improved cleanup of any containers left running by ``OpenstackLatentWorker``.
- Improved consistency of log messages produced by the reconfig script. Note that this output is not part of public API of Buildbot and may change at any time.
- Improved error message when try client cannot create a build due to builder being not configured on master side.
- Fixed exception when submitting builds via try jobdir client when the branch was not explicitly specified.
- Fixed handling of secrets in nested folders by the vault provider.

Features
--------

- Implemented report generator for new build requests
- Allow usage of Basic authentication to access GitHub API when looking for avatars
- Added support for default Pylint message that was changed in Pylint v2.0.
- Implemented support for configurable timeout in the reconfig script via new ``progress_timeout`` command-line parameter which determines how long it waits between subsequent progress updates in the logs before declaring a timeout.
- Implemented ``GitDiffInfo`` step that would extract information about what code has been changed in a pull/merge request.
- Add support ``--submodule`` option for the ``repo init`` command of the Repo source step.

Deprecations and Removals
-------------------------

- ``MessageFormatter`` will receive the actual builder name instead of ``whole buildset`` when used from ``BuildSetStatusGenerator``.

Bug fixes
---------

- Fixed a race condition in log handling of ``RpmLint`` and ``WarningCountingShellCommand`` steps resulting in steps crashing occasionally.
- Fixed incorrect state string of a finished buildstep being sent via message queue (5906).
- Reduced flickering of build summary tooltip during mouseover of build numbers (5930).
- Fixed missing data in Owners and Worker columns in changes and workers pages (5888, 5887).
- Fixed excessive debug logging in ``GerritEventLogPoller``.
- Fixed regression in pending buildrequests UI where owner is not displayed anymore (5940).
- Re-added support for ``lazylogfiles`` argument of ``ShellCommand`` that was available in old style steps.

Bug fixes
---------

- Updated Buildbot requirements to specify sqlalchemy 1.4 and newer as not supported yet.