Pytest-salt-factories

======================

Breaking Changes
----------------

- In `saltfactories.utils.cli_scipts.generate_script()`:

* For coverage tracking, both `coverate_db_path` and `coverage_rc_path` must be passed. They will not be infered by `root_dir`.
* `inject_coverage` was removed. (`135 <https://github.com/saltstack/pytest-salt-factories/issues/135>`_)
- The minimum Salt version in now `3004` (`136 <https://github.com/saltstack/pytest-salt-factories/issues/136>`_)


Trivial/Internal Changes
------------------------

- CI and internal changes:

* Start testing Salt 3005.x (rc2 for now)
* Skip testing 3005rc2 on windows and macOS for now.
* Lock system tests to a version of nox that still works
* Bump python version to 3.9 for lint workflow
* Bumped pylint requirement to `2.14.5` and cleaned up issues
* Don't build the salt minion container during test runs, pull an existing container. (`136 <https://github.com/saltstack/pytest-salt-factories/issues/136>`_)

======================

Breaking Changes
----------------

- Renamed the ``system_install`` configuration flag, markers and behaviours when set to ``system_service`` to better reflect what it's actually used for. (`96 <https://github.com/saltstack/pytest-salt-factories/issues/96>`_)


Features
--------

- Allow passing ``--python-executable`` to teak which python get's used to prefix CLI commands, when needed. (`129 <https://github.com/saltstack/pytest-salt-factories/issues/129>`_)
- Allow passing ``--scripts-dir`` to tell salt-factories where to look for the Salt daemon and CLI scripts.
The several scripts to the Salt daemons and CLI's **must** exist. Also, passing this option will additionally make
salt-factories **NOT** generate said scripts and set ``python_executable`` to ``None`` (`130 <https://github.com/saltstack/pytest-salt-factories/issues/130>`_)
- Added CLI support(``--system-service``) to change salt-factories to use Salt previously installed from the platform's package manager. (`131 <https://github.com/saltstack/pytest-salt-factories/issues/131>`_)
- Inject ``engines_dirs`` and ``log_handlers_dirs`` when ``system_service=True`` or ``scripts_path`` is not ``None``
These flags suggest that the salt being imported and used by salt-factories might not be the same as the one being tested.
So, in this case, make sure events and logging from started daemons still get forwarded to salt-factories. (`133 <https://github.com/saltstack/pytest-salt-factories/issues/133>`_)

======================

Bug Fixes
---------

- Bump deprecations targeted for 2.0.0 to 3.0.0 (`122 <https://github.com/saltstack/pytest-salt-factories/issues/122>`_)
- Try to pass ``loaded_base_name`` to each of Salt's loaders used in our ``Loaders`` class, if not supported, patch it at runtime. (`126 <https://github.com/saltstack/pytest-salt-factories/issues/126>`_)
- ``saltfactories.utils.warn_until()`` is now aware of Pytest's rewrite calls and properly reports the offending code. (`127 <https://github.com/saltstack/pytest-salt-factories/issues/127>`_)

======================

Improvements
------------

- Switch to internal start check ``callables``.

Additionally, significant container improvements, like:

* Get host ports to check from the container port bindings.
* Always terminate the containers.
* Support randomly assigned host port bindings

``skip_on_salt_system_install`` is now also a marker provided by ``pytest-salt-factories``. (`120 <https://github.com/saltstack/pytest-salt-factories/issues/120>`_)

======================

Improvements
------------

- Now that the new logging changes are merged into Salt's master branch, adjust detection of those changes on ``SaltKey``. (`118 <https://github.com/saltstack/pytest-salt-factories/issues/118>`_)


Bug Fixes
---------

- ``--timeout`` is now correctly passed for CLI factories when either ``timeout`` is defined on the configuration or when ``timeout`` is passed to the CLI factory constructor. (`117 <https://github.com/saltstack/pytest-salt-factories/issues/117>`_)


Trivial/Internal Changes
------------------------

- Test PyTest 7.0.x and 7.1.x & Fix tests requirements

* Don't allow ``pytest-subtests`` to upgrade pytest
* Test under PyTest 7.0.x and 7.1.x
* Force Jinja2 to be < 3.1 on Salt 3003.x
* Fix the requirements of the example ``echo-extension``
* Explicitly pass a timeout to Salt CLI's on spawning platforms.
* Windows builds were not getting passed the ``PYTEST_VERSION_REQUIREMENT`` env var. (`116 <https://github.com/saltstack/pytest-salt-factories/issues/116>`_)

======================

Bug Fixes
---------

- Fixed container tests not passing on macOS (`114 <https://github.com/saltstack/pytest-salt-factories/issues/114>`_)


Trivial/Internal Changes
------------------------

- Pin click on the black pre-commit hooks (`115 <https://github.com/saltstack/pytest-salt-factories/issues/115>`_)